Change birthday type #345
Closed
Change birthday type #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
service/impl/statistic:116 这里可能也需要同步改了 |
done |
jakezhu9
reviewed
Nov 22, 2023
| @@ -113,7 +113,7 @@ func (s statisticServiceImpl) Statistic(ctx context.Context) (*dto.Statistic, er | |||
| statistic.LinkCount = linkCount | |||
| statistic.VisitCount = postVisitCount + sheetVisitCount | |||
| statistic.LikeCount = postLikeCount + sheetLikeCount | |||
| statistic.Birthday = int64(birthday.(int)) | |||
| statistic.Birthday = birthday.(int64) | |||
| statistic.EstablishDays = (time.Now().UnixMilli() - int64(birthday.(int))) / (1000 * 24 * 3600) | |||
There was a problem hiding this comment.
117行这里还有一个 birthday 的转换，也改成 int64 吧
|
@textworld 进展如何？review中提到的最后一个小问题可以顺便改了吗，谢谢！ |
jakezhu9
approved these changes
Feb 4, 2024
|
@textworld 感谢你的贡献！由于剩下的问题和合并冲突还没解决，且长时间没有得到你的回复，我只能先将这个pr关闭。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#343 fix