Skip to content

fix(comment): fix comment query param when select #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix(comment): fix comment query param when select #34

merged 1 commit into from
Nov 20, 2022

Conversation

dopamine-joker
Copy link
Contributor

@dopamine-joker dopamine-joker commented Nov 20, 2022 •
edited
Loading

#33 fix

@1379
Copy link
Contributor

1379 commented Nov 20, 2022

Thanks!

@1379
Copy link
Contributor

1379 commented Nov 20, 2022

There is still a small problem.It should be judged whether 'keyword' parameter is empty .

if commentQuery.Keyword != nil && *commentQuery.Keyword!=""{
....
}

@dopamine-joker
Copy link
Contributor Author

commentQuery.Keyword != nil && *commentQuery.Keyword!=""

thanks for pointing out, i had fixed it.

@1379 1379 merged commit 2a82f7a into go-sonic:master Nov 20, 2022
@1379
Copy link
Contributor

1379 commented Nov 20, 2022

Thank you for your contribution，Invite you to become a member of the Go-SONIC project

@dopamine-joker
Copy link
Contributor Author

dopamine-joker commented Nov 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dopamine-joker @1379