Skip to content

fix(static-msg): do not report constants defined in another file #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025

Conversation

tmzane
Copy link
Member

@tmzane tmzane commented Jul 9, 2025

Fixes #92

@tmzane tmzane self-assigned this Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (fb7a246) to head (05888b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   81.89%   81.94%   +0.04%     
==========================================
  Files           2        2              
  Lines         370      371       +1     
==========================================
+ Hits          303      304       +1     
  Misses         51       51              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mark-rushakoff
Copy link

I confirmed this fixes the issue in my non-minimized, real encounter of the bug. Thanks for the quick fix.

@tmzane tmzane merged commit 261065f into main Jul 13, 2025
13 checks passed
@tmzane tmzane deleted the fix/static-msg-another-file-const branch July 13, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static message analyzer fails to observe unexported constant in other file in same package
2 participants