Skip to content

fix(static-msg): support binary expressions #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

fix(static-msg): support binary expressions #80

merged 3 commits into from
Apr 4, 2025

Conversation

tmzane
Copy link
Member

@tmzane tmzane commented Apr 4, 2025 •
edited
Loading

Fixes #79

@tmzane tmzane self-assigned this Apr 4, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (1a45042) to head (3aea780).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sloglint.go 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   85.14%   84.14%   -1.01%     
==========================================
  Files           2        2              
  Lines         303      309       +6     
==========================================
+ Hits          258      260       +2     
- Misses         37       39       +2     
- Partials        8       10       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmzane tmzane requested a review from mattdowdell April 4, 2025 14:15
ccoVeille
ccoVeille reviewed Apr 4, 2025
View reviewed changes
mattdowdell
mattdowdell approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@mattdowdell mattdowdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the points raised by @ccoVeille are worth thinking about a little before merging.

@tmzane tmzane requested a review from ccoVeille April 4, 2025 15:18
ccoVeille
ccoVeille reviewed Apr 4, 2025
View reviewed changes
@tmzane tmzane requested a review from ccoVeille April 4, 2025 15:58
@tmzane tmzane merged commit eae36ea into main Apr 4, 2025
10 of 12 checks passed
@tmzane tmzane deleted the static-msg-binary-expr branch April 4, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@mattdowdell mattdowdell mattdowdell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tmzane tmzane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-static-msg raise an error on static string concatenation
3 participants
@tmzane @ccoVeille @mattdowdell