Skip to content

fix(diff): swagger diff is not working for certain cases #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

schafle
Copy link

@schafle schafle commented Apr 27, 2023

Fixes #2929 and some more fixes

@schafle schafle force-pushed the diff-simple-schema-issue2929 branch from 2b43c33 to a89cd95 Compare April 27, 2023 19:57
@schafle
Copy link
Author

schafle commented Apr 28, 2023

This PR needs to be updated once #2933 is merged.

@casualjim casualjim force-pushed the diff-simple-schema-issue2929 branch from 65405b9 to 432d6c3 Compare April 28, 2023 22:42
@schafle schafle force-pushed the diff-simple-schema-issue2929 branch 2 times, most recently from f11adef to 59422f8 Compare April 29, 2023 06:11
Signed-off-by: Suraj Chafle <suraj.chafle@crowdstrike.com>
@schafle schafle force-pushed the diff-simple-schema-issue2929 branch from 59422f8 to f01971b Compare April 29, 2023 06:23
@schafle
Copy link
Author

schafle commented Apr 29, 2023

This is ready for merging now. I have updated changes in default values to use warning level.

@casualjim casualjim merged commit f657983 into go-swagger:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff tool does not find differences in form params
2 participants