Skip to content

Skip ContextValidate when the field is nil avoiding a panic fixing #2911 #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

Skip ContextValidate when the field is nil avoiding a panic fixing #2911 #2927

merged 2 commits into from
Apr 26, 2023

Conversation

romainbou
Copy link
Contributor

@romainbou romainbou commented Apr 23, 2023 •
edited
Loading

Fixes issue #2911

  • a4b8a2d modifies the model template to add the swag.IsZero condition.
  • 90c671d adds a small test verifying that the added condition is indeed in the resulting code

@romainbou
fix: ensure that the expressionValue isn't Zero before context valida…
a4b8a2d 
…tion

Signed-off-by: Romain Bouyé <romain@bouye.fr>
@romainbou
test: for go-swagger#2911 verifying that the new condition is in the …
90c671d 
…generated code

Signed-off-by: Romain Bouyé <romain@bouye.fr>
@romainbou romainbou force-pushed the 2911-fix-context-validator branch from 1e844ae to 90c671d Compare April 23, 2023 16:32
@romainbou romainbou changed the title Skip ContextValidate when the field is nil avoiding a panic finxing #2911 Skip ContextValidate when the field is nil avoiding a panic fixing #2911 Apr 26, 2023
@casualjim casualjim merged commit 0dbada3 into go-swagger:master Apr 26, 2023
@cthulhu-rider cthulhu-rider mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casualjim casualjim casualjim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainbou @casualjim