Fixes PropertiesSpecOrder not being used #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19a3f11 to
06db593
Compare
casualjim
approved these changes
Apr 26, 2023
Users can pass in --keep-spec-order to maintain the field order when generating go code. This flag is not actually respected, and fields are generated in alphabetical order. The reason for this is WithAutoXOrder generates a new YAML with x-order set on definition properties, however the new spec YAML is never actually used. This PR fixes this by reloading g.Spec if PropertiesSpecOrder is set.
06db593 to
feeb9c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can pass in --keep-spec-order to maintain the field order when generating go code. This flag is not actually respected, and fields are generated in alphabetical order. The reason for this is WithAutoXOrder generates a new YAML with x-order set on definition properties, however the new spec YAML is never actually used. This PR fixes this by reloading g.Spec if PropertiesSpecOrder is set.
The bug can be reproduced by running swagger@HEAD against
https://github.com/go-swagger/go-swagger/blob/master/fixtures/codegen/keep-spec-order.yml, e.g.swagger generate client --spec keep-spec-order.yml --keep-spec-ordercc @casualjim