Skip to content

#2748 passing request context to ConextValidate() #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2022
Merged

#2748 passing request context to ConextValidate() #2749

merged 1 commit into from
Mar 27, 2022
+2 −2

Conversation

dimovnike
Copy link
Contributor

Signed-off-by: Nick Dimov 3619341+dimovnike@users.noreply.github.com

@casualjim
Copy link
Member

Looks like there is a test that actually asserts the line you changed

@dimovnike
go-swagger#2748 passing request context to ConextValidate()
b037d6c 
Signed-off-by: Nick Dimov <3619341+dimovnike@users.noreply.github.com>
@dimovnike dimovnike force-pushed the 2748-contextvalidate branch from 9bc3321 to b037d6c Compare March 26, 2022 16:48
@dimovnike
Copy link
Contributor Author

dimovnike commented Mar 26, 2022 •
edited
Loading

Submitted a fix. The problem is that i can not run tests locally, they fail even when in master:

--- FAIL: TestClient (35.47s)                                                                                                                                                                                                          
    --- FAIL: TestClient/generate_client (0.00s)                                                                                                                                                                                       
        --- FAIL: TestClient/generate_client/packages_mangling (4.87s)                                                                                                                                                                 
            utils_test.go:30:                                                                                                                                                                                                          
                        Error Trace:    utils_test.go:30                                                                                                                                                                               
                                                                client_test.go:133                                                                                                                                                     
                                                                client_test.go:234                                                                                                                                                     
                                                                client_test.go:309                                                                                                                                                     
                        Error:          Expect "// Code generated by go-swagger; DO NOT EDIT.                                                                                                                                          
                                                                                                                                                                                                                                       
                                        package client                                
...

hope this will work!

@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #2749 (b037d6c) into master (aac662a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2749   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files          55       55           
  Lines        9597     9597           
=======================================
  Hits         7944     7944           
  Misses       1131     1131           
  Partials      522      522

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac662a...b037d6c. Read the comment docs.

@casualjim casualjim merged commit a543a92 into go-swagger:master Mar 27, 2022
@casualjim
Copy link
Member

@dimovnike what are the errors you see when you build locally? Can you share which OS + CPU architecture you are developing on?

@dimovnike
Copy link
Contributor Author

@dimovnike what are the errors you see when you build locally? Can you share which OS + CPU architecture you are developing on?

the build is ok but go test is failing. I use Ubuntu 20.04, and go version go1.16.7 linux/amd64.

I just found this in the error log:

note: module requires Go 1.17

its probably because of this. I will update golang and will try again.

@fredbi fredbi mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youyuanwu youyuanwu youyuanwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimovnike @casualjim @youyuanwu