Add sprig library for template functions. #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
reviewed
Mar 19, 2022
youyuanwu
approved these changes
Mar 19, 2022
4880ce5 to
694c615
Compare
Fixes go-swagger#2737 Alternative to go-swagger#2738 Removes duplicates from the funcmap that exist already in sprig. Note that this does leave the `hasPrefix` function overriding the one in sprig. This is because the sprig function expects arguments of the form `(prefix, string)` and the existing go-swagger function expects `(string, prefix)`. As to not cause a breaking change to the existing templating this was left as-is. Signed-off-by: Kevin Barbour <kevinbarbourd@gmail.com>
694c615 to
5168aca
Compare
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
==========================================
+ Coverage 82.77% 82.78% +0.01%
==========================================
Files 55 55
Lines 9583 9587 +4
==========================================
+ Hits 7932 7937 +5
+ Misses 1130 1129 -1
Partials 521 521
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sprig library for template functions.
Fixes #2737
Alternative to #2738
Removes duplicates from the funcMap that exist already in sprig.
Note that this does leave the
hasPrefixfunction overriding the one insprig. This is because the sprig function expects arguments of the form
(prefix, string)and the existing go-swagger function expects(string, prefix).As to not cause a breaking change to the existing templating this was
left as-is.
Signed-off-by: Kevin Barbour kevinbarbourd@gmail.com