support MarshalText in custom type
#2727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextMarshal in Custom TypeTextMarshal in custom type
TextMarshal in custom typeMarshalText in custom type
Codecov Report
@@ Coverage Diff @@
## master #2727 +/- ##
==========================================
- Coverage 82.91% 82.72% -0.19%
==========================================
Files 55 55
Lines 9548 9583 +35
==========================================
+ Hits 7917 7928 +11
- Misses 1117 1133 +16
- Partials 514 522 +8
Continue to review full report at Codecov.
|
|
Any chance you could make a test for this? I rarely touch this codebase and I don't want to break stuff in the future |
|
@casualjim yes, I had planned to do it as I pointed out in the PR message. It is already added in the last commit seconds ago! |
casualjim
approved these changes
Feb 26, 2022
|
Excellent, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives supports
MarshalTextin custom type.The problem is that possibly generates breaking change. So the solution here is:
MarshalTextfor custom type. Something likeswagger generate spec -o ./swagger.json --marshalTextPersonally, the second option can be good enough.
This code https://go.dev/play/p/tI99ntNYt62 generate this schema https://www.codepile.net/pile/KOGVJqym
I would like to create a couple of tests to verify that everything is correct but I don't have time to see how they are done in depth, could someone give me some clues where to start?
EDIT: I forgot: this generates the format of field to
uuidif the custom type is named asuuid,UUIDorUuid(L259).