avoid nil pointer panic #2691
Merged
avoid nil pointer panic #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casualjim
approved these changes
Jan 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
- Coverage 82.96% 82.94% -0.02%
==========================================
Files 54 54
Lines 9521 9524 +3
==========================================
+ Hits 7899 7900 +1
- Misses 1111 1112 +1
- Partials 511 512 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My crash for the issue #2690 goes away with this little patch.
I am not sure if this fixes the real issue, or if this is just a workaround.
Somebody with more expertise should inspect the patch before applying.