enhancement: Add .Pointer() method to enums.
#2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you run |
|
Done. |
casualjim
approved these changes
Dec 10, 2021
|
Is there anything else I need to do here? |
|
I fixed the build step on master, so if you update then the builds will hopefully pass |
Following the example of protobuf generated code, this change creates
a `.Pointer()` method on enums that creates a new, non-aliased pointer
to an enum value.
This means that you can call:
enumPtr := SomeEnumConst.Pointer()
to get a pointer to an enum value.
For reference, see:
https://developers.google.com/protocol-buffers/docs/reference/go-generated#enum
Signed-off-by: Paul Fisher <paul.fisher@tiledb.com>
go install github.com/kevinburke/go-bindata/go-bindata@latest
go generate ./generator
Signed-off-by: Paul Fisher <paul.fisher@tiledb.com>
Signed-off-by: Paul Fisher <paul.fisher@tiledb.com>
Codecov Report
@@ Coverage Diff @@
## master #2680 +/- ##
=======================================
Coverage 82.96% 82.96%
=======================================
Files 54 54
Lines 9521 9521
=======================================
Hits 7899 7899
Misses 1111 1111
Partials 511 511 Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of protobuf generated code, this change creates
a
.Pointer()method on enums that creates a new, non-aliased pointerto an enum value.
This means that you can call:
to get a pointer to an enum value.
For reference, see:
https://developers.google.com/protocol-buffers/docs/reference/go-generated#enum
I'm not sure what the best way to test this is; the way the existing test cases work is fairly opaque to me. Any pointers (heh)?