Skip to content

genspec: use schema only for params in body #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crazytyper
Copy link

Fixes command generate spec to only emit schema for parameters in: body.

As defined in https://swagger.io/specification/v2/#parameterObject.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #2661 (d8117e1) into master (48a66e4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
- Coverage   82.93%   82.93%   -0.01%     
==========================================
  Files          54       54              
  Lines        9507     9515       +8     
==========================================
+ Hits         7885     7891       +6     
- Misses       1111     1112       +1     
- Partials      511      512       +1     
Impacted Files Coverage Δ
codescan/route_params.go 95.34% <100.00%> (+0.30%) ⬆️
generator/structs.go 82.68% <0.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a66e4...d8117e1. Read the comment docs.

Signed-off-by: Crazy Typer <github.crazy.typer@gmail.com>
@crazytyper crazytyper force-pushed the fix-genspec-parameter-schema-vs-type branch from 72d7746 to d8117e1 Compare November 14, 2021 11:59
@casualjim casualjim merged commit 92bf85b into go-swagger:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants