Skip to content

Add github workflow to validate bindata.go #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Conversation

youyuanwu
Copy link
Member

Signed-off-by: Youyuan Wu youyuanwu@outlook.com

Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
@youyuanwu
Copy link
Member Author

youyuanwu commented Oct 2, 2021

The CI failure shows exactly why this new job is needed. templates and bindata are out of sync.

Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #2642 (5a2b3f0) into master (2a8cd03) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.02%     
==========================================
  Files          54       54              
  Lines        9505     9505              
==========================================
- Hits         7884     7883       -1     
- Misses       1110     1111       +1     
  Partials      511      511              
Impacted Files Coverage Δ
generator/structs.go 83.79% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8cd03...5a2b3f0. Read the comment docs.

@youyuanwu youyuanwu merged commit 77832e6 into master Oct 2, 2021
@youyuanwu youyuanwu deleted the validate-bindata branch October 2, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants