Skip to content

CLI code generation is ready for release #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2021
Merged

CLI code generation is ready for release #2562

merged 6 commits into from
Apr 18, 2021

Conversation

youyuanwu
Copy link
Member

Fixed issues and enhancements:

  • Added generate flag to specify cli app name
  • Fixed default response was not printed to stdout
  • Removed required flags marking. In future required check should be performed by generated validation code.
  • Implemented shared API auth, basic auth and oauth2 flags parsing.
  • Fixed bug that flags for body fields overwrite each other.
  • Updated documentations to include CLI.

dockerctl https://github.com/go-swagger/dockerctl was used for much of the testing, and is functional.
There are still some minor bugs and enhancement tracked under #139 (comment) .
Overall CLI generation is ready for release.

Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
…ave a flag

Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
Signed-off-by: Youyuan Wu <youyuanwu@outlook.com>
@youyuanwu youyuanwu requested a review from casualjim April 17, 2021 18:09
@casualjim casualjim merged commit b49f50b into master Apr 18, 2021
@casualjim casualjim deleted the CLI-4 branch April 18, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants