Bugfix: Client response headers panic #2548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
689072f to
fdc9b21
Compare
Codecov Report
@@ Coverage Diff @@
## master #2548 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 54 54
Lines 8451 8451
=======================================
Hits 6893 6893
Misses 1060 1060
Partials 498 498 Continue to review full report at Codecov.
|
Fixes the handling of response headers that have custom formatters where the header is not nullable to deal with the results from `UnmarshalText` of any strfmt type. resolves go-swagger#2544 Signed-off-by: kenjones <kenjones@cisco.com>
fdc9b21 to
e5b1301
Compare
casualjim
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the handling of response headers that have custom formatters
where the header is not nullable to deal with the results from
UnmarshalTextof any strfmt type.resolves #2544