Skip to content

generator: introduce support for "description" struct tag #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

redlicha
Copy link

Addresses #2541 : introduces support for --struct-tag description to the code generator.

Signed-off-by: Arne Redlich arne.redlich@gig.tech

Signed-off-by: Arne Redlich <arne.redlich@gig.tech>
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2542 (1baadc6) into master (731edff) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
+ Coverage   81.82%   81.83%   +0.01%     
==========================================
  Files          53       53              
  Lines        8394     8396       +2     
==========================================
+ Hits         6868     6871       +3     
+ Misses       1031     1030       -1     
  Partials      495      495              
Impacted Files Coverage Δ
generator/structs.go 83.91% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731edff...1baadc6. Read the comment docs.

@redlicha redlicha force-pushed the generator-introduce-support-for-desc-struct-tag branch from 9794e54 to a443dd1 Compare March 18, 2021 14:30
Copy link
Member

@casualjim casualjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that has a multiline comment

Signed-off-by: Arne Redlich <arne.redlich@gig.tech>
@redlicha
Copy link
Author

Can you add a test that has a multiline comment

Sure, I added one (in an additional commit, please let me know if you prefer to have it squashed).

@redlicha redlicha requested a review from casualjim March 22, 2021 07:58
@casualjim casualjim merged commit a4a4e83 into go-swagger:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants