added support for minProperties, maxProperties validations #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes go-swagger#2444 This PR adds support for minProperties and maxProperties validations in objects. * The validation remains standalone, independent from unmarshalling * The validation doesn't use json for plain maps, just len() * There is short-circuit to invalidate faster nil objects requiring at least one property. * The general case of objects with properties and additional properties requires intermediary JSON serialization. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
- Coverage 81.90% 81.84% -0.07%
==========================================
Files 53 53
Lines 8332 8343 +11
==========================================
+ Hits 6824 6828 +4
- Misses 1017 1023 +6
- Partials 491 492 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for minProperties and maxProperties validations in objects.
serialization.
Signed-off-by: Frederic BIDON fredbi@yahoo.com