Skip to content

Misc small fixes for PR149 comments that were lost #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

Misc small fixes for PR149 comments that were lost #154

merged 1 commit into from
Jul 9, 2024

Conversation

Quantu
Copy link
Contributor

@Quantu Quantu commented Jul 9, 2024 •
edited
Loading

  • Fix indent in README.md
  • Fix SetManagementKey example in README.md
  • Fix error handling when attempting to determine management key type from metadata
  • Add management key length validation and error message to ykAuthenticate

@ericchiang ericchiang merged commit 4259bca into go-piv:v2 Jul 9, 2024
@Quantu Quantu deleted the pr149fixes branch July 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericchiang ericchiang ericchiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quantu @ericchiang