Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-piv/piv-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.0
Choose a base ref
...
head repository: go-piv/piv-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.0
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 9, 2024

  1. Remove obsolete comments about Ed25519 support

    @AGWA @ericchiang
    AGWA authored and ericchiang committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8f5413e View commit details
    Browse the repository at this point in the history

  2. Rename skSignEd25519 to ykSignEd25519 since it now targets YubiKeys

    @AGWA @ericchiang
    AGWA authored and ericchiang committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bc889e4 View commit details
    Browse the repository at this point in the history

  3. Return an error if Ed25519ctx or Ed25519ph is used 

    Otherwise, an invalid signature will be returned.

As far as I can tell, the YubiKey only supports straight Ed25519.
    @AGWA @ericchiang
    AGWA authored and ericchiang committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2fae465 View commit details
    Browse the repository at this point in the history
Loading