Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-piv/piv-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.0
Choose a base ref
...
head repository: go-piv/piv-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.0
Choose a head ref
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 2, 2024

  1. Add ECDSAPrivateKey.ECDH which takes a *ecdh.PublicKey

    The current ECDSAPrivateKey.SharedKey method takes a *ecdsa.PublicKey.
    However, using crypto/ecdsa and crypto/elliptic for ECDH has been
    deprecated in the standard library in favor of crypto/ecdh.
    
    This commit adds a new ECDH method to ECDSAPrivateKey which takes
    a *ecdh.PublicKey.  This method has the same signature
    as ecdh.PrivateKey.ECDH, meaning the following interface can be be used
    to do ECDH with both standard library private keys and piv-go keys, providing
    the same flexibility as crypto.Signer and crypto.Decrypter:
    
    interface {
    	ECDH(*ecdh.PublicKey) ([]byte, error)
    }
    
    ECDSAPrivateKey.SharedKey has been re-implemented as a small wrapper around
    ECDSAPrivateKey.ECDH.
    AGWA authored and ericchiang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    7988525 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add new algorithms supported in firmware 5.7.x

    This commit supports the new algorithms supported on YubiKeys with a
    5.7.x firmware. It adds support for RSA-3072, RSA-4096, Ed25519, and
    X25519.
    
    Generating or importing X25519 keys is only supported with Go 1.20+,
    which adds support for the crypto/ecdh package.
    maraino authored and ericchiang committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    33d0d46 View commit details
    Browse the repository at this point in the history
  2. Fix suggestions from code review

    maraino authored and ericchiang committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2c985a1 View commit details
    Browse the repository at this point in the history
  3. Drop support for versions of Go lower than 1.20

    This commit removes the code to support Go 1.16 to 1.19, requiring now
    Go 1.20. With this requirement we can remove the build tags.
    
    It also renames the X25519 SharedKey to ECDH.
    maraino authored and ericchiang committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    12c06a0 View commit details
    Browse the repository at this point in the history
Loading