Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-pg/pg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v10.13.0
Choose a base ref
...
head repository: go-pg/pg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v10.14.0
Choose a head ref
  • 5 commits
  • 33 files changed
  • 4 contributors

Commits on Sep 30, 2024

  1. feat: Add support for header comments in ORM-generated queries (#2011)

    * feat: Added comment for public functions
    
    feat: Add query comments to headers for improved debugging
    
    This feature enhances debugging by including query comments in headers, allowing developers to trace the query's origin. By matching the query comment in the header, it's easier to identify the specific location in the code where the query was executed.
    
    * feat: Fixed query buffer append
    
    * feat: Changed query comment template
    
    * Reverted changes in test
    
    * Revised query comment implementation
    
    * Fixed appendComment func doc
    
    * Kept if cond only inside appendComment
    
    * Implemented tests for appendComment to verify proper escaping of comment symbols
    wwoytenko authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    898a35e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2024

  1. Bump golang.org/x/crypto from 0.21.0 to 0.31.0 in /extra/pgotel (#2013)

    Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0.
    - [Commits](golang/crypto@v0.21.0...v0.31.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/crypto
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 14, 2024
    Configuration menu
    Copy the full SHA
    a7fe379 View commit details
    Browse the repository at this point in the history
  2. Make reader and writer buffers configurable (#2014)

    * Make reader and writer buffers configurable
    
    Replace global sync pools with per-DB pools and make reader and writer buffers configurable.
    Default buffer sizes: 1Mb for reader buffer, 64Kb for writer buffer.
    
    Context:
    DB connections are pooled, usually there are not much of them available,
    so this is a resource used by goroutines, which have to wait for their
    turn in order to get a connection and use it before returning it back to
    the pool.
    
    Before getting into the waiting line every goroutine allocates a read
    and a write buffer from the sync.Pool of buffers.
    Currently hardcoded reader buffer size is 1Mb, so when 1000 goroutines
    wait in the queue, you get 1000Mb of buffers pre-allocated. So when an
    application unexpectedly gets a spike of traffic and all the database
    connections are being used, we don't get request timeouts as one could
    be expecting, the application is being OOM-killed instead.
    
    The patch addresses this issue by trading some allocations and
    (probably, though my benchmarks don't really show it) latency for the
    ability to serve more simultaneous connections.
    
    * Fix tests by using properly initialized Conn
    tony2001 authored Dec 14, 2024
    Configuration menu
    Copy the full SHA
    e55fd63 View commit details
    Browse the repository at this point in the history
  3. Bump golang.org/x/crypto from 0.21.0 to 0.31.0 (#2015)

    Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0.
    - [Commits](golang/crypto@v0.21.0...v0.31.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/crypto
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 14, 2024
    Configuration menu
    Copy the full SHA
    3dcdf7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bce00ad View commit details
    Browse the repository at this point in the history
Loading