Skip to content

Fix slog tests for 1.25 #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix slog tests for 1.25 #361

merged 1 commit into from
Mar 28, 2025

Conversation

hoeppi-google
Copy link
Contributor

A new group-related case was added,
much like in commit a6645b7.

fixes #360

A new group-related case was added,
much like in commit a6645b7.

fixes go-logr#360
@thockin
Copy link
Contributor

thockin commented Mar 28, 2025

#360 was also opened - I'd rather see if we can actually output the right thing before adding this

@thockin
Copy link
Contributor

thockin commented Mar 28, 2025

I had to page-in some of the details here. Thanks.

@thockin thockin merged commit c439f61 into go-logr:master Mar 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slogr tests need another exception for 1.25
3 participants