Skip to content

fix: 修复,当endpoint携带path前缀时的url请求路径 #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: 修复,当endpoint携带path前缀时的url请求路径 #3216

wants to merge 1 commit into from

Conversation

wuxingzhong
Copy link
Contributor

例:

http.WithEndpoint("https://127.0.0.1:443/api")

image

url中的结果,少拼接了api.

该pr修复这个问题, 看是否合理.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.68%. Comparing base (9106991) to head (8ed132f).

❗ Current head 8ed132f differs from pull request most recent head cc2aa0a. Consider uploading reports for the commit cc2aa0a to get more accurate results

Files Patch % Lines
transport/http/client.go 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
+ Coverage   84.62%   84.68%   +0.06%     
==========================================
  Files          88       88              
  Lines        3993     3996       +3     
==========================================
+ Hits         3379     3384       +5     
+ Misses        440      439       -1     
+ Partials      174      173       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shenqidebaozi
shenqidebaozi reviewed Mar 16, 2024
View reviewed changes
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test if it affects service discovery

@Vickko
Copy link

Vickko commented Nov 11, 2024

你好，请问这个问题有进展吗？现在所有endpoint都会丢失基础url之后的内容，导致使用http client时没有较好办法处理这个问题 @shenqidebaozi

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Hello, is there any progress on this issue? Now all endpoints will lose the content after the basic URL, resulting in no better way to deal with this problem when using http client @shenqidebaozi

windzhu0514
windzhu0514 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@windzhu0514 windzhu0514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always wanted this feature

@JasonLu233
Copy link

这个问题在当前版本 v2.8.4 还是存在，请问这个fix什么时候能合到主版本发布 @shenqidebaozi

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

This question still exists in the current version of v2.8.4. When will this fix be released in the main version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenqidebaozi shenqidebaozi shenqidebaozi left review comments

@windzhu0514 windzhu0514 windzhu0514 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wuxingzhong @codecov-commenter @Vickko @kratos-ci-bot @JasonLu233 @windzhu0514 @shenqidebaozi