feat: use writer directly in stdLogger. #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A benchmark for it.
goos: darwin
goarch: arm64
pkg: github.com/go-kratos/kratos/v2/log
BenchmarkNew-10 13301796 75.79 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/go-kratos/kratos/v2/log 1.344s
goos: darwin
goarch: arm64
pkg: github.com/go-kratos/kratos/v2/log
BenchmarkOld-10 6942644 160.6 ns/op 32 B/op 1 allocs/op
PASS
ok github.com/go-kratos/kratos/v2/log 1.525s |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
+ Coverage 81.62% 81.64% +0.01%
==========================================
Files 91 91
Lines 4163 4167 +4
==========================================
+ Hits 3398 3402 +4
Misses 587 587
Partials 178 178 ☔ View full report in Codecov by Sentry. |
shenqidebaozi
approved these changes
Dec 18, 2023
|
@hawkingrei And could you help me to review this code too? This code removed unnecessary "log.Output" so it doubles the performance of stdLogger. |
daemon365
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
log.stdLogger use log.Logger internally, and disable all options such as prefix or log flags. log.stdLogger use l.log like a io.Writer. So I removed l.log, use io.Writer directly.
Code "stdLogger use log.Logger with no options":
kratos/log/std.go
Lines 20 to 21 in 08300d8
Code "stdLogger not use any format features of log.Logger":
kratos/log/std.go
Lines 39 to 43 in 08300d8
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers:
I did not add test for stdLogger.Close, because there is no way to call Close outside.