Update imports for NATS #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
| @@ -9,8 +9,8 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/nats-io/gnatsd/server" | |||
| "github.com/nats-io/go-nats" | |||
| "github.com/nats-io/nats-server/server" | |||
There was a problem hiding this comment.
Probably should be "github.com/nats-io/nats-server/v2/server" now.
|
@wallyqs You wanna try updating re: above? |
|
@peterbourgon I'd like to update, but thought maybe should investigate more or maybe wait for something like this to merge #834 since if there are users not using modules yet and using go-kit then I think the import |
|
This is transparently supported back to Go 1.9.7 IIRC
…________________________________
From: Waldemar Quevedo <notifications@github.com>
Sent: Monday, June 10, 2019 3:51 PM
To: go-kit/kit
Cc: Derek Collison; Comment
Subject: Re: [go-kit/kit] Update imports for NATS (#881)
@peterbourgon<https://github.com/peterbourgon> I'd like to update, but thought maybe should investigate more or maybe wait for something like this to merge #834<#834> since if there are users not using modules yet and using go-kit then I think the import github.com/nats-server/v2/server may break for them.
I will take a look and try to update, for now since it is only for a pub/sub test the v1 version of the server would work ok since protocol backwards compatible.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#881?email_source=notifications&email_token=AAAV74LBHV5PZXQL3OP3Q6DPZ3LFPA5CNFSM4HU44NO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLOJJA#issuecomment-500622500>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAAV74MHV47ABPRBSHRPOJDPZ3LFPANCNFSM4HU44NOQ>.
|
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, sorry for the inconvenience but the NATS project has recently renamed some of its repos. Most of the time Github redirects would help but in case a project is using Go modules, it can help to have the correct paths in the imports just in case.
Signed-off-by: Waldemar Quevedo wally@synadia.com