Skip to content

Replace "x/net/context" import with "context" #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2018
Merged

Replace "x/net/context" import with "context" #810

merged 1 commit into from
Dec 7, 2018

Conversation

marselester
Copy link
Contributor

Regarding the #563 issue. It's possible to replace golang.org/x/net/context with the standard library context package since grpc/grpc-go#2439 is merged.

@Terminator637
Copy link

Why is this issue still open?

@peterbourgon
Copy link
Member

Wow, that's great, thank you.

@peterbourgon peterbourgon merged commit f688401 into go-kit:master Dec 7, 2018
@marselester marselester deleted the grpc-rm-old-ctx branch December 8, 2018 03:02
@dio
Copy link

dio commented Apr 28, 2019

🎉

jamesgist pushed a commit to jamesgist/kit that referenced this pull request Nov 1, 2024
@marselester @peterbourgon
Replace "x/net/context" import with "context" (go-kit#810)
4465e06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marselester @Terminator637 @peterbourgon @dio