Skip to content

sd/etcdv3: serve the keepalive response channel #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

sd/etcdv3: serve the keepalive response channel #803

merged 1 commit into from
Mar 11, 2019

Conversation

fangdingjun
Copy link
Contributor

read and discard keepalive response,
make etcd library not to complain
fix #799

@fangdingjun
sd/etcdv3: serve the keepalive response channel
7023e5d 
read and discard keepalive response,
make etcd library not to complain
fix go-kit#799
@peterbourgon
Copy link
Member

Thanks!

@peterbourgon peterbourgon merged commit 90f6ad6 into go-kit:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sd/etcdv3 keepalive channel not served
2 participants
@fangdingjun @peterbourgon