Skip to content

metrics/internal/convert: use method value insetad of lambda #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

metrics/internal/convert: use method value insetad of lambda #767

merged 1 commit into from
Oct 1, 2018

Conversation

quasilyte
Copy link
Contributor

Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.

@quasilyte
metrics/internal/convert: use method value insetad of lambda
234ef9a 
Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.
@quasilyte quasilyte mentioned this pull request Oct 1, 2018
Closed
@quasilyte
Copy link
Contributor Author

CI failure looks unrelated to the change:

#!/bin/bash -eo pipefail
go get -t github.com/go-kit/kit/...

# github.com/miekg/dns
../../miekg/dns/msg_helpers.go:271:8: undefined: strings.Builder
../../miekg/dns/serve_mux.go:43:9: undefined: strings.Builder
Exited with code 2

@peterbourgon peterbourgon merged commit 81cf14a into go-kit:master Oct 1, 2018
@quasilyte quasilyte deleted the quasilyte/unlambda branch October 2, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quasilyte @peterbourgon