Enhance package log docs. #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
approved these changes
Jan 11, 2017
|
|
||
| wg.Wait() | ||
|
|
||
| // Unordered output: |
There was a problem hiding this comment.
Whoa, didn't know that was a thing.
There was a problem hiding this comment.
@peterbourgon It was added in Go 1.7 but I was surprised to discover it missing from the docs at golang.org/pkg/testing. There is an oblique reference in the release notes, but the best place to find it is by running go help testfunc.
There was a problem hiding this comment.
@peterbourgon See also: golang/go#10149.
There was a problem hiding this comment.
Glad I could help.. I had basically the exact same issue with a library I wrote a while back so I figured it would be useful.. the deploy became complicated because godoc has to be backwards compatible so that kind of became a crap show for deployments. =(
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #346 and #415.