-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Description
Edit: Due to lots of feature churn in the last few weeks/months, I've been convinced that it makes more sense to hold off on a 1.0.0 until things settle. Notes in comments below.
—
Hello! I want to cut a v1.0.0 release in the near future. This issue is created per the request of @ChrisHines to serve as a notice to anyone who may be interested, for example to raise questions, concerns, or propose specific additions.
The only thing outstanding that I'd like to get in is a promotion of log/experimental_level to log/level. I've asked @seh to weigh in on that, as he's previously commented on the package. Otherwise, let me know your thoughts. I'll leave this open until at least the weekend, so another 5 days.
edit: outstanding issues I'd want to resolve before a 1.0.0
- log: promote experimental_level to level #476 — Merge log/experimental_level to level; move existing levels to deprecated_levels
- Move to Standard library Context package #420 / Use stdlib context instead of golang.org/x/net/context #421 — use stdlib context where possible
- log: default StdlibAdapter file key should be "caller" #432 / Rename file term to caller #437 — log: StdlibAdapter "file" key to "caller"
- Optional: log: StdlibAdaptor timestamp value is weird in logfmt format #434 — log: normalize StdlibAdapter timestamp format
- Optional: Why no transport/http.EncodeJSONRequest? #431 — transport: implement http.EncodeJSONRequest
- Evaluate breaking change: Replace log.Context with log.With/WithPrefix? #474 — Replace log.Context with log.With/WithPrefix?
If anyone feels strongly about either of those two Optionals, (cc: @willfaught) please get your PRs in within the next few days...