generator: support MySQL 5.7 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL 5.7 does not support CTE's. Refactor the table column metadata query to avoid the CTE.
|
Perfect. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 5.7 does not support CTE's. Refactor the table column metadata query to avoid the CTE. Fixes regression introduced in 8864667; see also issue #111.
Some of the MySQL tests are failing on 5.7 but not any of the generator ones, just some SELECT ones that use syntax that MySQL 5.7 doesn't have, so that's only to be expected. As a side note, to import
test_sample.sqlfrom the testdata repo into 5.7 with (AFAIK) default settings, I had to add the lineSET SQL_MODE='ALLOW_INVALID_DATES';or it'd complain about an invalid default for the columntimestamp_ptr. I'm not sure if I can/should do anything about that, so I left it as is.