Skip to content

Conversation

higordasneves
Copy link
Contributor

@higordasneves higordasneves commented May 6, 2025

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Add option to exclude database DSN address tracer attribute.

User Case Description

Use tracing plugin without report the database DSN address.
I don't want to add the information to the span for two reasons:

  1. I don't want the database address exposed in the APM.
  2. when the attribute is added as server.address, DD (Datadog) doesn't recognize it as a DB span. In previous versions, before the address implementation, it appeared in the tab normally.

image

@zstone12
Copy link
Collaborator

zstone12 commented May 7, 2025

@higordasneves Yes, it's indeed necessary to add this option.Please run the gofumpt -w -extra .to format the code and submit an additional commit .

@higordasneves
Copy link
Contributor Author

@higordasneves Yes, it's indeed necessary to add this option.Please run the gofumpt -w -extra .to format the code and submit an additional commit .

@zstone12 hello! ok, done. tks

@zstone12 zstone12 merged commit 6d2f7a6 into go-gorm:master May 7, 2025
2 checks passed
@zstone12
Copy link
Collaborator

zstone12 commented May 7, 2025

@higordasneves Nice Work!Thank you for your contribution.

@higordasneves
Copy link
Contributor Author

@zstone12 thank you! Can you generate a git tag, please?

@zstone12
Copy link
Collaborator

zstone12 commented May 7, 2025

@zstone12 thank you! Can you generate a git tag, please?

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants