Allow users to include stacktrace in events #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
509dc7a to
9d32b82
Compare
|
@sysradium Stack trace inside exception events that is indeed necessary. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
OpenTelemetry automatically records panics as events:
https://github.com/open-telemetry/opentelemetry-go/blob/0c49ece8056617e5c1d1318805e74cbbbc33c7b2/sdk/trace/span.go#L465
But as you can it does not record stacktraces. I think it is useful if you don't use otel logger with
logging.WithRecordStackTraceInSpan