fix(schema): check the hook function parameter type #7468
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves hook function validation by ensuring that the hook functions in models have the correct parameter type. The change adds a runtime check that verifies the package path of the hook's first parameter and logs a warning if it doesn't match the expected type.
- Adds a check to verify that the hook function parameter is from the "gorm.io/gorm" package.
- Logs a warning when the hook function parameter type is incorrect.
Comments suppressed due to low confidence (1)
schema/schema.go:317
- Consider returning an error instead of only logging a warning when the hook function parameter type is incorrect. This change would enforce the expected contract and help prevent silent misconfigurations.
if inVarPkg := methodValue.Type().In(0).Elem().PkgPath(); inVarPkg != "gorm.io/gorm" {
jinzhu
reviewed
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
User Case Description