Skip to content

Fix: Composite primary key with auto-increment value returns 0 after insert #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2023
Merged

Fix: Composite primary key with auto-increment value returns 0 after insert #6127

merged 4 commits into from
Mar 10, 2023

Conversation

truongns
Copy link
Contributor

@truongns truongns commented Mar 7, 2023

Fix #4930 workaround for databases that support auto-increment in composite primary key.

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fix issue #4930

User Case Description

In MySQL, you can have composite primary key with auto-increment
For example:

https://github.com/nash90/playground/blob/7a82d16b1b1b626df01cf43089b302de7c2a6bd9/models.go#L63-L70

type CompositeKeyProduct struct {
	ProductPointID int       `gorm:"primaryKey;autoIncrement:true;column:product_point_id"`
	LanguageCode   int       `gorm:"primaryKey;autoIncrement:false;column:language_code"`
	Code           string    `gorm:"column:code"`
	Name           string    `gorm:"column:name"`
	CreatedAt      time.Time `gorm:"column:created_at"`
	UpdatedAt      time.Time `gorm:"column:updated_at"`
}

Upon insert new record into CompositeKeyProduct with the following values:
https://github.com/nash90/playground/blob/7a82d16b1b1b626df01cf43089b302de7c2a6bd9/main_test.go#L26-L30

prod := &CompositeKeyProduct{
		LanguageCode: 56,
		Code:         "56",
		Name:         "Test56",
}

res := DB.Create(prod)

expected

prod.ProductPointID: 1

actual

prod.ProductPointID: 0

This Pull Request is aiming to fix the above case

a631807682
a631807682 reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more tests to describe it? just like doing in playground.

truongns
truongns commented Mar 8, 2023
View reviewed changes
a631807682
a631807682 reviewed Mar 8, 2023
View reviewed changes
@truongns
schema.go: use field.AutoIncrement instead of field.TagSettings["AUTO…
ddd0a11 
…INCREMENT"], add test to check autoincrement:false

create_test.go: remove unused code: drop table CompositeKeyProduct
@jinzhu jinzhu merged commit ed47415 into go-gorm:master Mar 10, 2023
black-06
black-06 reviewed Apr 19, 2023
View reviewed changes
tests/create_test.go
}

newProd := &CompositeKeyProduct{}
if err := DB.First(&newProd).Error; err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not rigorous here. When I run the test repeatedly, the inserted record product id is self-increasing, so it will fail.
I suggest to do DropTable before AutoMigrate.

if err := DB.Migrator().DropTable(&CompositeKeyProduct{}); err != nil {
	t.Fatalf("failed to migrate, got error %v", err)
}

@black-06 black-06 mentioned this pull request Apr 19, 2023
Merged
3 tasks
black-06 added a commit to black-06/gorm that referenced this pull request Apr 19, 2023
@black-06
fix create test
7a1c450 
go-gorm#6127 (comment)
jinzhu pushed a commit that referenced this pull request Apr 21, 2023
@black-06
fix: unit test (#6250)
ac20d9e 
* fix: unit test

* fix create test

#6127 (comment)

* style: rename to adaptorSerializerModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-06 black-06 black-06 left review comments

@a631807682 a631807682 a631807682 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

composite key auto-increment returned 0 upon Create of new record
4 participants
@truongns @a631807682 @black-06 @jinzhu