Issue 6054: Unscoped not working with PreLoad on Joins #6058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
reviewed
Feb 15, 2023
There was a problem hiding this comment.
Please fix the code format by gofumpt. https://github.com/go-gorm/gorm/pull/6058/files
|
I ran |
a631807682
approved these changes
Feb 15, 2023
6 tasks
|
@jinzhu Thank-you for merging. Could you please advise when you next expect to release |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6054
What did this pull request do?
Fixed use of
Unscoped()onPreload(..).User Case Description
Retrieval of models with
Unscoped()andPreload(..)does not include soft-deleted records.Use of
Unscoped()should include soft-deleted records.