feat: Unique Constraint Violation error translator for different drivers #6004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can add If the dialector implements |
This is a good idea, I will update the PR & also create a new PR for one of the drivers. |
3 tasks
c36db2a to
d975b80
Compare
a631807682
approved these changes
Feb 22, 2023
This was referenced Mar 6, 2023
a631807682
reviewed
Mar 7, 2023
|
Hello, will this new |
I would like to know too! And while I'm at it, how should I go about updating my project dependencies to use the new gorm release that has this error included? |
Documentation has been added go-gorm/gorm.io#664 |
3 tasks
This was referenced May 31, 2023
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 1, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 1, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to bfabio/developers-italia-api
that referenced
this pull request
Jun 16, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to bfabio/developers-italia-api
that referenced
this pull request
Jun 16, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 17, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 17, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 17, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
bfabio
added a commit
to italia/developers-italia-api
that referenced
this pull request
Jun 17, 2023
Remove common.ErrDBUniqueConstraint, which was used as a workaround for the lack of abstraction in gorm. With the update in go-gorm/gorm#6004 we can now fully use gorm for db related errors (fe. gorm.ErrDuplicatedKey).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
It will enable developers to have a better error response when there is a unique key constraint violation detected in different SQL engines.
Addresses these issues: #4037, #4135, #5651, #6002.
There is no new import or any dependency on any driver, the implementation works by marshaling the returned error from any query and comparing it to SQL engine's default error message by looking after the error code.
User Case Description
When there is a unique key constraint violation error it will return
gorm.ErrDuplicatedKey. Basically, it will look if there is a translation available for a specific type of error, if there was one it will return that translation, otherwise, it will return the given untranslated error.