Skip to content

Prevent empty LDAP search from deactivating all users (#9879) #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2020
Merged

Prevent empty LDAP search from deactivating all users (#9879) #9890

merged 3 commits into from
Jan 20, 2020

Conversation

dioss-Machiel
Copy link

@dioss-Machiel dioss-Machiel commented Jan 20, 2020 •
edited by lafriks
Loading

Backport #9879

@lafriks lafriks changed the title Backport of #9879 for 1.10 Add option to prevent LDAP from deactivating everyhing on empty search (#9879) Jan 20, 2020
@sapk sapk added this to the 1.10.4 milestone Jan 20, 2020
@sapk sapk added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 20, 2020
@zeripath zeripath changed the title Add option to prevent LDAP from deactivating everyhing on empty search (#9879) Prevent empty LDAP search from deactivating all users (#9879) Jan 20, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2020
@techknowlogick techknowlogick merged commit 68bca62 into go-gitea:release/v1.10 Jan 20, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
6 participants
@dioss-Machiel @zeripath @guillep2k @techknowlogick @sapk @GiteaBot