Skip to content

Move comment action out of models package #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Move comment action out of models package #9254

wants to merge 3 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 5, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #9254 into master will increase coverage by 0.01%.
The diff coverage is 52.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9254      +/-   ##
==========================================
+ Coverage   41.03%   41.05%   +0.01%     
==========================================
  Files         556      556              
  Lines       72535    72596      +61     
==========================================
+ Hits        29763    29801      +38     
- Misses      39027    39047      +20     
- Partials     3745     3748       +3
Impacted Files Coverage Δ
services/pull/merge.go 51.11% <0%> (ø) ⬆️
modules/notification/webhook/webhook.go 37.31% <100%> (ø) ⬆️
services/issue/status.go 57.14% <100%> (ø) ⬆️
models/issue_comment.go 42.85% <100%> (ø) ⬆️
modules/notification/base/null.go 64.51% <100%> (ø) ⬆️
modules/notification/notification.go 72.51% <100%> (ø) ⬆️
modules/notification/mail/mail.go 22.38% <100%> (ø) ⬆️
modules/notification/ui/ui.go 74.46% <100%> (ø) ⬆️
models/error.go 32.42% <20%> (-0.25%) ⬇️
models/issue.go 52.18% <36.66%> (+0.07%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c67a8...f582fd2. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2019
@techknowlogick techknowlogick added this to the 1.11.0 milestone Dec 5, 2019
@lunny lunny mentioned this pull request Dec 12, 2019
Merged
@lunny lunny closed this Dec 12, 2019
@lunny lunny deleted the lunny/move_comment_action branch December 12, 2019 06:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @codecov-io @techknowlogick @GiteaBot