Skip to content

Fix panic when diff (#9187) #9193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Fix panic when diff (#9187) #9193

merged 1 commit into from
Nov 28, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 28, 2019

  • fix panic when diff
  • improve code

backport from #9187

@lunny
Fix panic when diff (go-gitea#9187)
4b8c5dc 
* fix panic when diff

* improve code
@lunny lunny added the type/bug label Nov 28, 2019
@lunny lunny added this to the 1.10.1 milestone Nov 28, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2019
@techknowlogick techknowlogick merged commit c4e52d2 into go-gitea:release/v1.10 Nov 28, 2019
@lunny lunny deleted the lunny/fix_diff2 branch November 28, 2019 15:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @techknowlogick @guillep2k @GiteaBot