Skip to content

Move pull webhook to notification #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Move pull webhook to notification #8805

merged 2 commits into from
Nov 5, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 3, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 3, 2019
@codecov-io
Copy link

codecov-io commented Nov 3, 2019 •
edited
Loading

Codecov Report

Merging #8805 into master will increase coverage by 0.01%.
The diff coverage is 1.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8805      +/-   ##
==========================================
+ Coverage   41.21%   41.22%   +0.01%     
==========================================
  Files         543      543              
  Lines       69768    69780      +12     
==========================================
+ Hits        28756    28769      +13     
- Misses      37319    37324       +5     
+ Partials     3693     3687       -6
Impacted Files Coverage Δ
services/pull/pull.go 38.57% <0%> (+4.82%) ⬆️
modules/notification/webhook/webhook.go 37.8% <0%> (-2.38%) ⬇️
modules/notification/base/null.go 62.5% <0%> (-2.72%) ⬇️
modules/notification/notification.go 72.81% <0%> (-2.95%) ⬇️
services/pull/review.go 0% <0%> (ø) ⬆️
services/pull/merge.go 40.46% <100%> (-0.57%) ⬇️
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
modules/task/migrate.go 24.35% <0%> (-3.85%) ⬇️
models/error.go 31.75% <0%> (-1.24%) ⬇️
models/repo.go 48.62% <0%> (+0.05%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e7715...32350ec. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2019
@lunny lunny force-pushed the lunny/move_pull_webhook branch from 53a30eb to 32350ec Compare November 5, 2019 10:24
@lunny lunny merged commit aaeef29 into go-gitea:master Nov 5, 2019
@lunny lunny deleted the lunny/move_pull_webhook branch November 5, 2019 11:04
@lunny lunny mentioned this pull request Nov 6, 2019
Merged
6 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @zeripath @6543 @GiteaBot