Skip to content

Leave non-dated issues for last when sorting by by nearest due date #8871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2019
Merged

Leave non-dated issues for last when sorting by by nearest due date #8871

merged 4 commits into from
Nov 9, 2019

Conversation

guillep2k
Copy link
Member

"Sort by nearest due date" should leave the ones without due date for last. For example:

Currently:

#_2324          (no due date)
#_2626          (no due date)
#_1234    Oct 3 (past due)
#_1432    Nov 7 (due Today)
#_5232    Nov 8 (due Tomorrow)

Expected:

#_1234    Oct 3 (past due)
#_1432    Nov 7 (due Today)
#_5232    Nov 8 (due Tomorrow)
#_2324          (no due date)
#_2626          (no due date)

This PR fixes that.

@guillep2k guillep2k mentioned this pull request Nov 7, 2019
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2019
@lunny lunny added the type/bug label Nov 9, 2019
@codecov-io
Copy link

codecov-io commented Nov 9, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1f3ba69). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #8871   +/-   ##
========================================
  Coverage          ?   41.2%           
========================================
  Files             ?     544           
  Lines             ?   70096           
  Branches          ?       0           
========================================
  Hits              ?   28886           
  Misses            ?   37514           
  Partials          ?    3696
Impacted Files Coverage Δ
models/issue.go 51.2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3ba69...1d35db3. Read the comment docs.

@zeripath zeripath merged commit a647a54 into go-gitea:master Nov 9, 2019
@guillep2k guillep2k mentioned this pull request Nov 14, 2019
Closed
7 tasks
@guillep2k guillep2k deleted the fix-duedatesort branch November 20, 2019 13:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@guillep2k @codecov-io @6543 @jolheiser @lunny @zeripath @GiteaBot @sapk