upgrade github.com/russross/blackfriday #8503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Oct 14, 2019
| blackfriday.HTML_OMIT_CONTENTS | | ||
| blackfriday.HTML_USE_SMARTYPANTS | ||
| blackfriday.SkipHTML | | ||
| blackfriday.Smartypants |
There was a problem hiding this comment.
It appears blackfriday.HTML_OMIT_CONTENTS was sunset without a direct replacement, see upstream, it may be that some other flag or option within the blackfriday.HTMLRenderer struct may replace this.
lunny
reviewed
Oct 14, 2019
russross/blackfriday made breaking api changes and has recently released v2.0.1. Some symbol renaming occurred, so this change consumes that delta. It will also be required to rework the modules/markup/markdown.Renderer module set to meet the new blackfriday.Renderer interface. Close #8502.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
russross/blackfriday made breaking api changes and has recently released
v2.0.1. Some symbol renaming occurred, so this change consumes that
delta.
It will also be required to rework the modules/markup/markdown.Renderer
struct set to meet the new blackfriday.Renderer interface.
Close #8502.