Skip to content

[Backport] Fix milestone num_issues (#8221) #8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2019
Merged

[Backport] Fix milestone num_issues (#8221) #8400

merged 2 commits into from
Oct 7, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 6, 2019 •
edited
Loading

Backport of #8221

@lunny @6543
Fix milestone num_issues (go-gitea#8221)
911419c 
* fix milestone num_issues

* update missing completeness

* only update milestone closed number when closed issue is assigned a new milestone or clear milestone

* fix tests

* fix update milestone num

* fix completeness calculate

* make completeness calucation more clear
@6543 6543 changed the title Backport 8221 [Backport] Fix editor commit to new branch if PR disabled (#8221) Oct 6, 2019
@6543 6543 mentioned this pull request Oct 6, 2019
Merged
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2019
@6543 6543 changed the title [Backport] Fix editor commit to new branch if PR disabled (#8221) [Backport] Fix milestone num_issues (#8221) Oct 6, 2019
@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

@lunny @techknowlogick backport ...
... drone done

@6543
Copy link
Member Author

6543 commented Oct 6, 2019

will close #8069

@6543
Copy link
Member Author

6543 commented Oct 7, 2019

@guillep2k point

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2019
@lunny lunny added the type/bug label Oct 7, 2019
@lunny lunny added this to the 1.9.4 milestone Oct 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2019
@lunny
Copy link
Member

lunny commented Oct 7, 2019

make L-G-T-M work

@lunny lunny merged commit b0dcf41 into go-gitea:release/v1.9 Oct 7, 2019
@6543 6543 deleted the backports_8221 branch October 7, 2019 09:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.4
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @guillep2k @GiteaBot