Move front end source files to web_src and generate index.js minify version #8440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Shouldn't we lock to a specific version of the minifier? Otherwise CI build might differ from the committed version. |
silverwind
reviewed
Oct 9, 2019
| .PHONY: webpack | ||
| webpack: npm | ||
| npm install webpack -g | ||
|
|
There was a problem hiding this comment.
This is unnecessary, just run npm install --save-dev webpack which will add it as a proper dependency. To run it, use npx webpack <args> afterwards.
|
This doesn't really solve #8430. All that webpack config does is copy source to destination. If you want to minify, you would at least want to add a minify plugin, for which I recommend |
gary-kim
suggested changes
Oct 10, 2019
|
@gary-kim we already have a |
|
🤦 Forgot about LESS. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8430 and this will also reduce gitea package size since we moved frontend source files from public directory.