Fix lax comparison in validation tests #7815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to
the test code, you'll notice that only Errors' Messages are being
compared:
--- PASS: Test_ValidURLValidation/Invalid_schema (0.00s)
binding_test.go:43: [Url] [Url]
FieldNames and Classification are ignored in comparison.
Moreover, an Errors slice with a single Error with empty message
is formatted as '[]' (the same as empty slice), which is also
error-prone. I discovered this when working on go-gitea#7791 when one test which
was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG
This commit changes the test to do the comparison properly.
Codecov Report
@@ Coverage Diff @@
## master #7815 +/- ##
=========================================
- Coverage 41.41% 41.4% -0.01%
=========================================
Files 474 474
Lines 63876 63876
=========================================
- Hits 26453 26451 -2
- Misses 33978 33980 +2
Partials 3445 3445
Continue to review full report at Codecov.
|
lafriks
approved these changes
Aug 10, 2019
sapk
approved these changes
Aug 11, 2019
|
make L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add
t.Logf("%+v %+v", actual, testCase.expectedErrors)tothe test code, you'll notice that only Errors' Messages are being
compared:
FieldNamesandClassificationare ignored in comparison.Moreover, an
Errorsslice with a singleErrorwith empty messageis formatted as
[](the same as empty slice), which is alsoerror-prone. I discovered this when working on #7791 when one test which
was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG
This commit changes the test to do the comparison properly.