Skip to content

Backport #7617 #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

Backport #7617 #7626

merged 1 commit into from
Jul 26, 2019

Conversation

silverwind
Copy link
Member

@silverwind
Fix syntax highlight initialization (go-gitea#7617)
b9bd281 
* Fix syntax highlight initialization

Previously hljs was initialized via a function that relies on the
DOMContentLoaded event, registerd after jQuery's 'ready' event. I assume
that with the recent jQuery update, DOMContentLoaded may not be
guaranteed to fire after 'ready'. Fixed this via vanilla JS initalization.

Fixes: go-gitea#7559

* semicolon
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2019
@zeripath zeripath merged commit 650fdce into go-gitea:release/v1.9 Jul 26, 2019
@lafriks lafriks added this to the 1.9.0 milestone Jul 26, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@wxiaoguang wxiaoguang deleted the backport-7617 branch January 26, 2025 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @mrsdizzie @zeripath @lafriks @GiteaBot