Skip to content

Send webhook after commit finished #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2019
Merged

Send webhook after commit finished #7681

merged 2 commits into from
Jul 31, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 31, 2019

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 31, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 31, 2019
@codecov-io
Copy link

codecov-io commented Jul 31, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ce27e48). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7681   +/-   ##
=========================================
  Coverage          ?   41.25%           
=========================================
  Files             ?      471           
  Lines             ?    63754           
  Branches          ?        0           
=========================================
  Hits              ?    26301           
  Misses            ?    34020           
  Partials          ?     3433
Impacted Files Coverage Δ
models/issue_assignees.go 39.89% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce27e48...ea21188. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 31, 2019
@lunny lunny merged commit 0742f71 into go-gitea:master Jul 31, 2019
@lunny lunny deleted the lunny/fix_webhook_assign branch July 31, 2019 09:25
lunny added a commit to lunny/gitea that referenced this pull request Jul 31, 2019
@lunny
fix duplicated webhook when creating issue with assignees (go-gitea#7681
5bef460 
)
@lunny lunny mentioned this pull request Jul 31, 2019
Merged
@lunny lunny added backport/done All backports for this PR have been created backport/v1.9 type/bug and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jul 31, 2019
lafriks pushed a commit that referenced this pull request Jul 31, 2019
@lunny @lafriks
fix duplicated webhook when creating issue with assignees (#7681) (#7684
ee43d20 
)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @zeripath @GiteaBot