Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 1, 2019

Fix pull view ui when there is no status check. This is caused by #6845 .

Before

image

After

image

@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 1, 2019
@lunny lunny added this to the 1.9.0 milestone Jul 1, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 1, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2019
@techknowlogick
Copy link
Member

CI Fail

@lunny lunny force-pushed the lunny/fix_pull_merge_section branch from b6fcb60 to 7cd0fbf Compare July 1, 2019 03:50
@codecov-io
Copy link

Codecov Report

Merging #7335 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7335      +/-   ##
==========================================
- Coverage   41.29%   41.29%   -0.01%     
==========================================
  Files         466      466              
  Lines       63186    63186              
==========================================
- Hits        26095    26091       -4     
- Misses      33680    33685       +5     
+ Partials     3411     3410       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6af9d...7cd0fbf. Read the comment docs.

@techknowlogick techknowlogick merged commit 1772c6b into go-gitea:master Jul 1, 2019
@lunny lunny deleted the lunny/fix_pull_merge_section branch July 1, 2019 04:50
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* fix pull view ui merge section

* fix tests

* fix tests
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants